Testing : v1.59.0

[lapineige]

Problem

• New app version available : 1.51
• Fix #296
• Fix https://github.com/YunoHost-Apps/synapse_ynh/issues/307

PR Status

• [x] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[lapineige]

!testme

[yunohost-bot]

:rocket:

[PxBCPG]

How is it going?

[lapineige]

!testme

[yunohost-bot]

Meow :cat2:

[Gredin67]

tested and approved

[ericgaspar]

!testme

[yunohost-bot]

:carousel_horse:

[nathanael-h]

Upgraded from stable (1.47) ok.

[tituspijean]

!testme

[yunohost-bot]

Fingers crossed!

[Tagadda]

This is fixed in 1.15.1, and 1.15.2 is out o/ Time to upgrade :rocket:

[Josue-T]

!testme

[yunohost-bot]

:carousel_horse:

[PxBCPG]

time to pull into the main branch! Synapse 1.55 is already released!

[nathanael-h]

Upgrade synapse to 1.55.2 ok for me on Debian 10, x64. Thanks!

[ericgaspar]

!testme

[yunohost-bot]

May the CI gods be with you!

[Josue-T]

!testme

[yunohost-bot]

May the CI gods be with you!

[Josue-T]

!testme

[yunohost-bot]

May the CI gods be with you!

[nathanael-h]

In the logs: "You have enabled open registration without any verification. This is a known vector for " 506476 WARNING Apr 12 04:25:50 python[25901]: synapse.config._base.ConfigError: You have enabled open registration without any verification. This is a known vector for spam and abuse. If you would like to allow public registration, please consider adding email, captcha, or token-based verification. Otherwise this check can be removed by setting the enable_registration_without_verification config option to true."

This is a feature of latest version to refuse to start with open registration. See this page: https://github.com/matrix-org/synapse/releases/tag/v1.56.0

[Tagadda]

Another possible fix is to enable the email verification:

diff --git a/conf/homeserver.yaml b/conf/homeserver.yaml
index 4dcb30a..81c26ae 100644
--- a/conf/homeserver.yaml
+++ b/conf/homeserver.yaml
@@ -857,8 +857,8 @@ enable_registration: __ALLOWED_ACCESS__

 # The user must provide all of the below types of 3PID when registering.
 #
-#registrations_require_3pid:
-#  - email
+registrations_require_3pid:
+  - email
 #  - msisdn

 # Explicitly disable asking for MSISDNs from the registration

[nathanael-h]

Yes, it would be better. I wanted to push this modification, but I do not have write access on this branch.

[tituspijean]

!testme

[yunohost-bot]

:rocket:

[nathanael-h]

!testme

[yunohost-bot]

Fingers crossed!

[nathanael-h]

Is the failure due to a problem on the ci?

In logs: Warning: Expected to find an existing snapshot snap_nourlinstall but it doesn't exist yet .. will attempt to create it Error: In use

[Tagadda]

Error: In use indicates that the CI could not restore the snapshot before running the next test, so the install fails. CI issue. Restarted the job.

[Josue-T]

@tituspijean are we sure that email registration works ?

[tituspijean]

Let's check, or find an alternative if it doesn't. :)

[MayeulC]

I have updated my synapse install to this branch yesterday, it works fine. I haven't checked email registrations though, as public registrations are disabled on my homeserver.

[Josue-T]

Let's check, or find an alternative if it doesn't. :)

I asked the question because I'm not sure that synapse is able to send correctly email actually. Normally synapse need to be authenticated to postfix to be able to send correctly the email

[nathanael-h]

Actually synapse as no email server config https://github.com/YunoHost-Apps/synapse_ynh/blob/testing/conf/homeserver.yaml#L1260-1268

Maybe it should be tested in another PR. For this PR with v 1.56 we might use this setting enable_registration_without_verification in config and set it to true. This would allow us to merge this long-term PR.

[Josue-T]

!testme

[yunohost-bot]

May the CI gods be with you!

[shukon]

Anything one could do to help with this? Not sure where to start, but if someone would point me I might try to help. Willing to wait, just wondering what kind of blocker it is...

[lapineige]

Let's bump it straight to 1.58.1 #308 ?

[nathanael-h]

Hi everyone, this PR was opened a long time ago, to upgrade synapse version. Since then many versions were released, this PR updated, but we did not merge to master. So actually the version provided by the app catalog is quite old. Would be it possible to merge this PR, and to open new PR per version, so that we could be more agile and have more often releases. (I know that at some points, the version provided by this PR was not stable enough to be merged, but I think we are good to go now). By the way, big thanks to all contributors, especially @Josue-T for your work on this app.

[MayeulC]

The issue here is upstream disabling open registrations. Is anyone using that feature in yunohost anyway?

We could check if registrations are open at upgrade-time (at the very beginning), and abort if they are, while displaying a message to the users, and directing them to a wiki page or something.

[nathanael-h]

I thought the issue about open registrations was addressed in this commit 398d97b3b71738ab0779fd8ea3a8674f4d6cc703, wasn't it?

[tituspijean]

We need to tackle the issues raised by the latest CI test with the backups first.

[shukon]

@tituspijean so I looked at the logs but I'm not sure, what the actual problem is. I haven't been packaging apps yet though I intend to start on it. Something changed in the way yunohost backs stuff up? I found four things related to the error,

• blowfish is deprecated
• CAST5 is deprecated
• TypeError: load() missing 1 required positional argument: 'Loader'
• AttributeError: module 'jinja2' has no attribute 'Markup'

Now I'm not sure, which of those are just warnings or irrelevant. Or a symptom of different problem. I'm willing to spend time solving this, since I use the synapse pkg to manage a few small communities and it stopped working with the mautrix bridges by now, so I really feel like updating makes sense :) but I need a bit of help...

[Thatoo]

As there is this PR to update to v1.59, https://github.com/YunoHost-Apps/synapse_ynh/pull/310 , is there any reason to keep this PR open?

[ericgaspar]

As there is this PR to update to v1.59, #310 , is there any reason to keep this PR open?

Yes there is, this is the testing branch and will be merged to master.

V1.59 -> testing -> master

[MayeulC]

You might as well want to pull https://github.com/matrix-org/synapse/releases/tag/v1.59.1, which is supposed to only have a minor fix for a long-standing issue.

[Josue-T]

Let's merge as the app is broken since a long time...