search

YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

Disable password connection if app private - SSO/CAS access only #315

Closed Gredin67 closed 11 months ago

Gredin67 commented 2 years ago

Describe the bug

Currently to connect through CAS/SSO with element_ynh you need to go through a bunch of clicking to find the continue with CAS button. Which is aweful UX when the synapse is set private (registration disabled) and only Yunohost SSO users can connect.

Steps to reproduce

Connect as Yunohost user in the SSO, go to the Element URL, do the too many steps to Connect through CAS.

Expected behavior

If the app is installed as private enable_registration: False then We can avoid some clicking by changing following settings in homeserver.yaml

password_config:
   # Uncomment to disable password login
   #
   enabled: false
eauchat commented 1 year ago

As mentioned in a comment in #339, I'm not so sure it's great that password login is disabled, because some client are not always working with sso login. However I understand and agree with the issue of too many steps and bad current experience having to click so many times. Don't know too much what's the best way to approach the issue. And maybe I'm wrong now and sso login is now better working in more recent clients.

Thatoo commented 1 year ago

Well sso login works nicely between Element and Yunohost. I didn't encounter any issue for a while.

Josue-T commented 1 year ago

There are this pr with partially fix the issue i think: https://github.com/YunoHost-Apps/element_ynh/pull/79