YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

fix for element wich generate cors error on FFX #317

Closed rosbeef closed 1 year ago

rosbeef commented 2 years ago

fix element to works on firefox

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Josue-T commented 2 years ago

Hello,

Are you sure that the patch should be on this file and not in the server_name.conf ?

rosbeef commented 2 years ago

Sorry I search in my files an yes it is the right place

rosbeef commented 2 years ago

Server_name is, as I understand the nginx conf for usersid domain extension usually domain.tld Nginx.conf is for the server subdomain name usually matrix.domain.tld

Josue-T commented 2 years ago

Well,

I'm a bit confused, because we already have a well-known configuration for the client here. Could you please provide me matrix documentation who say that theses informations should be on the synapse domain. And if it's the case we should move all the client config to the synapse domain and not add a new config.

rosbeef commented 2 years ago

Hello sorry i'm travelling back and can not respond you well. I found nothing inside matrix docs but did not search well. The only thing I can tell you is that from ffx 101 I couldn't connect due to a cors error, I needed to add this exception to the matrix host server domain (not the user domain (neither the client domain)) which are different in my configuration.

rosbeef commented 1 year ago

seem to not be needed anymore