wrong permissions on /etc/logrotate.d/synapse

MayeulC commented 1 year ago

Describe the bug

I have used that synapse package for a while. I routinely had log files in excess of 100G, which is a bit too much to my taste.

I decided to investigate why logs were not rotated, and found that I had the wrong permissions on the logrotate configuration file. I did not change those manually, so other might have the same issue.

Permissions were 666 instead of 640 or 644, owned by root. Pihole and mautrix_synapse had the same issue.

Context

Hardware: Old 86_64 PC
YunoHost version: 4.4.2.12
I have access to my server: every way
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: I don't think so, not applicable here
Using, or trying to install package version/branch: stable

Steps to reproduce

Unsure when the permissions were changed.

Expected behavior

The upgrade script or even better, yunohost helper, should fix permissions by doing chmod go-w on the config file

Josue-T commented 1 year ago

Well it's mainly an issue on the yunohost helper.

lapineige commented 4 months ago

I still have the issue. Should it be reported upstream ?

error: skipping "/var/log/matrix-synapse/homeserver.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.

JimboJoe commented 2 months ago

Same issue here, with logrotate service failing to start...

YunoHost-Apps / synapse_ynh