Closed Linkid closed 1 year ago
!testme
Hello,
Have you tested because it completely fail on the CI ?
Hi. Thanks for the review. I've only tested the function I've modified, not all the yunohost scripts.
Now, I've tested the package installation and it is working fine. I've updated the commit and the description in the PR.
!testme
We probably should do the same thing for the coturn config cf #341
Closing as #360 should be better
Problem
homeserver.yaml
file, URLs insso/client_whitelist
are not well formatted: there are all in the same line instead of being a list, and this line is over-indented.Solution
\n
from the generated list of domains__DOMAIN_WHITELIST_CLIENT__
var in the template before applying the template. Usingynh_add_config
escapes\n
whereasynh_replace_string
doesn't.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)