YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

fix(conf): start a new line for each domain to whitelist #332

Closed Linkid closed 1 year ago

Linkid commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Josue-T commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:v: Test Badge

Josue-T commented 1 year ago

Hello,

Have you tested because it completely fail on the CI ?

Linkid commented 1 year ago

Hi. Thanks for the review. I've only tested the function I've modified, not all the yunohost scripts.

Linkid commented 1 year ago

Now, I've tested the package installation and it is working fine. I've updated the commit and the description in the PR.

Josue-T commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:stuck_out_tongue_winking_eye: Test Badge

Josue-T commented 1 year ago

We probably should do the same thing for the coturn config cf #341

Josue-T commented 1 year ago

Closing as #360 should be better