disable-password-if-private

Gredin67 commented 1 year ago

Problem

see https://github.com/YunoHost-Apps/synapse_ynh/issues/315

Solution

disable password login by default if synapse is installed as private app (registration disabled). We can suppose users will then only connect through the SSO/CAS

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Josue-T commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:v:

eauchat commented 1 year ago

If this is merged to master, I think it would be important to have a very clear documentation on the readme about how to reverse it.

Personally I wouldn't be so pleased that password login is disabled and may prefer the default behaviour of both sso and password login, because many times matrix clients I've used weren't working properly with either sso login or password login (even element itself is fairly buggy about it). I managed not to stay logged out because of one of the two solutions working not always the same one depending on the device, time, client...

Josue-T commented 1 year ago

There are this PR with partially fix the issue i think: https://github.com/YunoHost-Apps/element_ynh/pull/79

I think it would be good to add this as a settings into the config panel if we merge this.

Gredin67 commented 1 year ago

solved by #356

YunoHost-Apps / synapse_ynh