YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 42 forks source link

Fix lists in config #360

Closed Gredin67 closed 1 year ago

Gredin67 commented 1 year ago

Problem

Solution

PR Status

Gredin67 commented 1 year ago

!testme @Josue-T is #341 already solved?

Josue-T commented 1 year ago

!testme @Josue-T is #341 already solved?

No

yunohost-bot commented 1 year ago

Alrighty! Test Badge

Gredin67 commented 1 year ago

It looks like there is some issue related to backup_core_only. Should the CI test run both with backup_core_only=true and then backup_core_only=false ?

 > Removing the app...
112344 INFO Due of the backup core only feature the data directory in '/home/yunohost.app/matrix-synapse' was not removed. It need to be removed manually to purge app user data.
> Reinstalling after removal.
Running: yunohost app install --force /app_folder -a "domain=sub.domain.tld&path=/path&is_free_registration=1&server_name=domain.tld&admin=package_checker&is_public=&jitsi_server=jitsi.riot.im"
2954 INFO Installing synapse...
17194 INFO [....................] > Validating installation parameters... [00h00m,02s]
17237 WARNING A data directory already exist. Data was renamed to /home/yunohost.app/matrix-synapse20230112.101750
 > Backup of the application...
1872 WARNING It's hightly recommended to make your backup when the service is stopped. Please stop synapse service with this command before to run the backup 'systemctl stop matrix-synapse.service'
Josue-T commented 1 year ago

It looks like there is some issue related to backup_core_only. Should the CI test run both with backup_core_only=true and then backup_core_only=false ?

 > Removing the app...
112344 INFO Due of the backup core only feature the data directory in '/home/yunohost.app/matrix-synapse' was not removed. It need to be removed manually to purge app user data.
> Reinstalling after removal.
Running: yunohost app install --force /app_folder -a "domain=sub.domain.tld&path=/path&is_free_registration=1&server_name=domain.tld&admin=package_checker&is_public=&jitsi_server=jitsi.riot.im"
2954 INFO Installing synapse...
17194 INFO [....................] > Validating installation parameters... [00h00m,02s]
17237 WARNING A data directory already exist. Data was renamed to /home/yunohost.app/matrix-synapse20230112.101750
 > Backup of the application...
1872 WARNING It's hightly recommended to make your backup when the service is stopped. Please stop synapse service with this command before to run the backup 'systemctl stop matrix-synapse.service'

Don't worry about this it mainly for user to make correctly the backup to keep the data integrity.

Josue-T commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:carousel_horse: Test Badge

Gredin67 commented 1 year ago

about external_ip I'm pretty sure my syntax is wrong, and I could not test it..