Closed Gredin67 closed 1 year ago
!testme
@Josue-T we still have an issue https://github.com/YunoHost-Apps/synapse_ynh/blob/master/scripts/install#L40
\n
does not add a new line in homeserver.yaml
EDIT : should be solved #376 , should be tested
@Josue-T perhaps we should warn the user that upgrade can be very long because of chown on the user data path. Or tell to chown before launching the upgrade. Last upgrade was stuck for hours and it took me a while to understand that chown was the reason.
@Josue-T perhaps we should warn the user that upgrade can be very long because of chown on the user data path. Or tell to chown before launching the upgrade. Last upgrade was stuck for hours and it took me a while to understand that chown was the reason.
Or maybe I saw something (in nextcloud) that using find
and changing only the file which don't have the correct permission is more efficient.
But well anyway it's not a regression just an improvement which could be done.
@Josue-T a quick workaround would be to chown at the very beginning of the upgrade (before backing up the app) and to add a
ynh_script_progression --message="MAY TAKE HOURS: Changing permissions on user files" --weight=30
Then the upgrade would fail before starting anything critical if the user kills it manually.
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)