Correct newline in config yaml lists with $'\n'

[Gredin67]

Problem

• \n not correctly transformed in a newline in config files

Solution

• use $'\n'

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[Josue-T]

Well ok but did you test the upgrade with your patch and did you check that the turn config file are correct ?

[Gredin67]

I tested the lines manually, but upgrade indeed fails https://paste.yunohost.org/raw/ivayademod

[Gredin67]

!testme

[yunohost-bot]

:stuck_out_tongue_winking_eye:

[Josue-T]

Please don't change the check process, you should update your personnal repos just must have all branch named "old_version_for_CI_X"

[Gredin67]

Does the CI not run on the main repo? I thought it was an issue related to the fact that you deprecated buster recently. I could'nt find the commit, but yeah if it's in another branch..

Btw if you could have a look at my PRs to get it merged.. It's been a while and I was just giving a hand.

Le 10 mai 2023 08:14:47 GMT+02:00, Josue-T @.***> a écrit :

Please don't change the check process, you should update your personnal repos just must have all branch named "old_version_for_CI_X"

-- Reply to this email directly or view it on GitHub: https://github.com/YunoHost-Apps/synapse_ynh/pull/376#issuecomment-1541412234 You are receiving this because you authored the thread.

Message ID: @.***>

[Gredin67]

!testme

[yunohost-bot]

:carousel_horse:

[Gredin67]

!testme

[yunohost-bot]

May the CI gods be with you!

[Josue-T]

!testme

[yunohost-bot]

May the CI gods be with you!

[Josue-T]

I think we should use sed directly instead of the helper to work correctly because with the helper there are too many things between the helper call and the sed command.

[Gredin67]

I will not work on this further because I don't understand anything of it. Anyone motivated ? @YunoHost-Apps/matrix-bridges

[Gredin67]

We have an insecure client whitelist, see :

WARNING: An entry such as "https://my.client" is insecure, because it
    # will also match "https://my.client.evil.site", exposing your users to
    # phishing attacks from evil.site. To avoid this, include a slash after the
    # hostname: "https://my.client/".

[Josue-T]

Fixed by #426

[gautz]

@tituspijean for reference to https://forum.yunohost.org/t/synapse-upgrade-n-in-coturn-conf/26883/2 I never managed to get the correct syntax..