YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 43 forks source link

Testing #399

Closed ericgaspar closed 10 months ago

ericgaspar commented 10 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 10 months ago

!testme

yunohost-bot commented 10 months ago

:carousel_horse: Test Badge

Josue-T commented 10 months ago

Well why did you disable multi instance mode ?

ericgaspar commented 10 months ago

I suspect multi-install teste set to 0 because the multi-install doesn't work (CI failes)? https://github.com/YunoHost-Apps/synapse_ynh/blob/a1c7e5a1777f252499da1d4946d499cd5587a0c8/check_process#L18

ericgaspar commented 10 months ago

!testme

yunohost-bot commented 10 months ago

:rocket: Test Badge

Gredin67 commented 10 months ago

can we merge this in testing https://github.com/YunoHost-Apps/synapse_ynh/pull/356 and further test before merging in master ?

Gredin67 commented 10 months ago

and probably too long, but would be nice to move to packaging v2 sometime soon https://github.com/YunoHost-Apps/synapse_ynh/issues/401

Josue-T commented 10 months ago

I suspect multi-install teste set to 0 because the multi-install doesn't work (CI failes)?

https://github.com/YunoHost-Apps/synapse_ynh/blob/a1c7e5a1777f252499da1d4946d499cd5587a0c8/check_process#L18

Well I see. I think we should temporary disable the multi instance test but keep enabled in the manifest.json (if possible). And when we migrate to packaging v2 find a way to enable again multi-instance tests.

Anyway we can't remove muti-instance flag in manifest.json it wight break multi-instance installation.

ericgaspar commented 10 months ago

!testme

yunohost-bot commented 10 months ago

:stuck_out_tongue_winking_eye: Test Badge