Testing - Githubissues

YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost

https://matrix.org/

GNU General Public License v3.0

79 stars 43 forks source link

Testing #402

Closed Josue-T closed 10 months ago

Josue-T commented 10 months ago

Problem

App not up to date
Php config not up to date

Solution

Update

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Josue-T commented 10 months ago

!testme

yunohost-bot commented 10 months ago

Alrighty!

Gredin67 commented 10 months ago

now that https://github.com/YunoHost/yunohost/pull/815 is merged, can we avoid to create a dedicated yunohost user for synapse to send email ?

Gredin67 commented 10 months ago

basically here https://github.com/YunoHost-Apps/synapse_ynh/blob/master/conf/homeserver.yaml#L2249-L2250 and here https://github.com/YunoHost-Apps/synapse_ynh/blob/master/scripts/install#L150-L156

Josue-T commented 10 months ago

now that YunoHost/yunohost#815 is merged, can we avoid to create a dedicated yunohost user for synapse to send email ?

No, cf: https://github.com/YunoHost/yunohost/pull/977#issuecomment-1702246195

But please for a discussion like that create an issue it's better.