Testing - Githubissues

YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost

https://matrix.org/

GNU General Public License v3.0

79 stars 43 forks source link

Testing #407

Closed Josue-T closed 9 months ago

Josue-T commented 9 months ago

Problem

App not up to date
Legacy config panel

Solution

Update
Rework config panel

PR Status

[x] Code finished and ready to be reviewed/tested
[x] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

Josue-T commented 9 months ago

!testme

yunohost-bot commented 9 months ago

:sunflower:

Gredin67 commented 9 months ago

@Josue-T feel free to squash before merging in master, my history is an entire mess :D

Josue-T commented 9 months ago

@Josue-T feel free to squash before merging in master, my history is an entire mess :D

Well it's a bit too late. This should be done when merging you PR.

Gredin67 commented 9 months ago

@rosbeef upgrading from a custom 1.81 config panel branch, I get account_threepid_delegates_msisdn' should be initialized with a value during install or upgrade

rosbeef commented 9 months ago

At firts look i Dont understand, because line 290 of upgrade script this value is set to "" (empty). If there was no existing values before.