YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 43 forks source link

Upgrade from 1.93.0 to 1.96.1 fails due to fail2ban #430

Closed MayeulC closed 7 months ago

MayeulC commented 7 months ago

Describe the bug

In the upgrade script:

WARNING - /usr/share/yunohost/helpers.d/fail2ban: ligne 106: logpath : variable sans liaison [means unbound variable]

This may be the issue? fail2ban then refuses to start with:

51,966 fail2ban                [1918448]: ERROR   Async configuration of server failed
51,960 fail2ban                [1918448]: ERROR   Failed during configuration: Have not found any log file for synapse jail

The upgrade rolls back and restores the backup, but fail2ban remains broken. Restarting it manually afterwards works. Possibly similar to #329 ?

Context

Logs

https://paste.yunohost.org/raw/qiruzopoli

aibosss commented 7 months ago

Same from 1.94 to 1.96.1

TiberiusRegenschein commented 7 months ago

Ican confirm the behavior on my system too: Context

Hardware: NUC x64 machine
YunoHost version: 11.2.6
I have access to my server: ssh, web admin
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
Using, or trying to install package version/branch: 1.96.1~ynh1
If upgrading, current package version: 1.94.0~ynh1
OniriCorpe commented 7 months ago

It’s a core bug, nor a package bug ^^"

I try to patch it here: https://github.com/YunoHost/yunohost/pull/1743

Josue-T commented 7 months ago

Yes I confirm it's a regression from https://github.com/YunoHost/yunohost/pull/1737

alexAubin commented 7 months ago

Should be fixed in yunohost 11.2.7

TiberiusRegenschein commented 7 months ago

You guys really rock :smile: Problem solved for me with yunohost 11.2.7

TabTwo commented 7 months ago

Can confirm, 11.2.7 did the trick. Thank you for the fast fix.