YunoHost-Apps / synapse_ynh

Matrix server (synapse) package for YunoHost
https://matrix.org/
GNU General Public License v3.0
79 stars 43 forks source link

Explicitly define PHP version (set to 8.2) #466

Open CodeShakingSheep opened 3 weeks ago

CodeShakingSheep commented 3 weeks ago

Problem

Synapse CAS Server runs on PHP 7.4 on my server (as 7.4 is the default PHP version). I want it to run on the newer PHP version 8.2.

Solution

I defined PHP8.2 explicitly in manifest.toml's apt resourcs. php8.2-fpm instead of php-fpm. So, according to https://github.com/YunoHost/yunohost/blob/d5e054fe80002862bd5966d61b20e9fafcf0578e/helpers/utils#L472 PHP version should be set by this.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

CodeShakingSheep commented 3 weeks ago

!testme

yunohost-bot commented 3 weeks ago

:carousel_horse: Test Badge

yunohost-bot commented 3 weeks ago

:bug: Test Badge

Josue-T commented 3 weeks ago

Hello,

Why changing the php version ? The official debian version is just the most stable version. To me no reason to change this.

CodeShakingSheep commented 3 weeks ago

Hello,

Why changing the php version ? The official debian version is just the most stable version. To me no reason to change this.

Hi, because PHP 7.4 is outdated since 28th November 2022. See https://www.php.net/supported-versions.php and https://www.php.net/eol.php.

CodeShakingSheep commented 5 days ago

!testme

yunohost-bot commented 5 days ago

:v: Test Badge

yunohost-bot commented 5 days ago

:bug: Test Badge

CodeShakingSheep commented 5 days ago

@alexAubin @ericgaspar What do you think about this? My php7.4-fpm service is only running for this app. As I would like to save resources on my server it would be great to shut php7.4-fpm service down and upgrade synapse php version before.