YunoHost-Apps / tandoor_ynh

Tandoor package for YunoHost
https://tandoor.dev
MIT License
3 stars 5 forks source link

Update from 1.4.8 breaks the installation #35

Closed johndoe0815 closed 1 month ago

johndoe0815 commented 1 year ago

Describe the bug

I have updated tandoor from 1.4.8 to 1.4.9 in yunohost. During installation, the following was shown:

Updating a configuration file...
File /var/www/tandoor/recipes/version.py has been manually modified since the installation or last upgrade. So it has been duplicated in /var/cache/yunohost/appconfbackup//var/www/tandoor/recipes/version.py.backup.20230508.102241
--- /var/cache/yunohost/appconfbackup//var/www/tandoor/recipes/version.py.backup.20230508.102241 2023-03-14 22:10:37.000000000 +0000
+++ /var/www/tandoor/recipes/version.py 2023-05-08 10:22:43.169996398 +0000
@@ -1,2 +1,2 @@
-VERSION_NUMBER = "0.0.0"
-BUILD_REF = ""
+VERSION_NUMBER = "1.4.9"
+BUILD_REF = ""
\ No newline at end of file
Upgrading dependencies via pip...
Running migrations and generatic static files...

I have never modivied the version.py.

In the end the update was reported as a success. However now when opening tandoor, I only get a Server Error (500) displayed.

Steps to reproduce

Update tandoor in yunohost.

navanchauhan commented 1 year ago

the error seems to suggest a checksum mismatch, but it should not affect the app itself. Let me investigate

navanchauhan commented 1 year ago

In the meanwhile, you should be able to restore to the pre-upgrade version

johndoe0815 commented 1 year ago

If I want to restore the backup (/home/yunohost.backup/archives/tandoor-pre-upgrade1.tar), yunohost says that this is not possible due to the application already being installed. Do I need to uninstall first and hope for the backup to work as expected?

navanchauhan commented 1 year ago

Yes, you will have to uninstall it first. You can also take another backup in case you want to be super sure about this version tooBest,NavanOn May 15, 2023, at 03:22, johndoe0815 @.***> wrote: If I want to restore the backup (/home/yunohost.backup/archives/tandoor-pre-upgrade1.tar), yunohost says that this is not possible due to the application already being installed. Do I need to uninstall first and hope for the backup to work as expected?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

johndoe0815 commented 1 year ago

Thanks. I uninstalled and recovered the backup from 1.4.8., works again. So the update broke it indeed.

johndoe0815 commented 1 year ago

Tried another update to the new version 1.4.11 from my current 1.4.8. Same issue, Server Error 500 after the update. This is the log from the update:

tandoor wird jetzt aktualisiert...
Loading installation settings...
Backing up the app before upgrading (may take a while)...
Stopping a systemd service...
Making sure dedicated system user exists...
Upgrading source files...
Upgrading dependencies...
Upgrading NGINX web server configuration...
Updating a configuration file...
File /var/www/tandoor/recipes/version.py has been manually modified since the installation or last upgrade. So it has been duplicated in /var/cache/yunohost/appconfbackup//var/www/tandoor/recipes/version.py.backup.20230612.082517
--- /var/cache/yunohost/appconfbackup//var/www/tandoor/recipes/version.py.backup.20230612.082517 2023-03-14 22:10:37.000000000 +0000
+++ /var/www/tandoor/recipes/version.py 2023-06-12 08:25:18.820622818 +0000
@@ -1,2 +1,2 @@
-VERSION_NUMBER = "0.0.0"
-BUILD_REF = ""
+VERSION_NUMBER = "1.4.11"
+BUILD_REF = ""
\ No newline at end of file
Upgrading dependencies via pip...
Running migrations and generatic static files...
Building frontend...
warning " > workbox-webpack-plugin@5.1.4" has unmet peer dependency "webpack@^4.0.0".
warning "@vue/cli-service > @babel/helper-compilation-targets@7.20.7" has unmet peer dependency "@babel/core@^7.0.0".
warning " > @babel/eslint-parser@7.19.1" has unmet peer dependency "@babel/core@>=7.11.0".
warning " > @vue/composition-api@1.7.1" has incorrect peer dependency "vue@>= 2.5 < 2.7".
warning " > babel-loader@9.1.2" has unmet peer dependency "@babel/core@^7.12.0".
warning " > babel-loader@9.1.2" has unmet peer dependency "webpack@>=5".
warning "bootstrap-vue > bootstrap@4.6.2" has unmet peer dependency "jquery@1.9.1 - 3".
warning " > workbox-webpack-plugin@6.5.4" has unmet peer dependency "webpack@^4.4.0 || ^5.9.0".
warning " > @typescript-eslint/eslint-plugin@4.33.0" has incorrect peer dependency "@typescript-eslint/parser@^4.0.0".
- Building for production...
(node:738171) [DEP_WEBPACK_SINGLE_ENTRY_PLUGIN] DeprecationWarning: SingleEntryPlugin was renamed to EntryPlugin
(Use `node --trace-deprecation ...` to show where the warning was created)
[BABEL] Note: The code generator has deoptimised the styling of /var/www/tandoor/vue/src/utils/openapi/api.ts as it exceeds the max of 500KB.
(node:738171) [DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated.
BREAKING CHANGE: No more changes should happen to Compilation.assets after sealing the Compilation.
Do changes to assets earlier, e. g. in Compilation.hooks.processAssets.
Make sure to select an appropriate stage from Compilation.PROCESS_ASSETS_STAGE_*.
Upgrading systemd configuration...
Upgrading logrotate configuration...
Integrating service in YunoHost...
Starting a systemd service...
Reloading NGINX web server...
Upgrade of tandoor completed
tandoor aktualisiert
Upgrade vollständig

I do not see any release notes and there is no more comments on this issue. What is the status on this?

navanchauhan commented 1 year ago

was busy with my classes, let me look into this now

navanchauhan commented 1 year ago
image

It looks like the upgrade gets stuck on this step, and then eventually times out (but is returned as a success?) -> thus the server error

johndoe0815 commented 1 year ago

Problem continues for me with version 1.5.4, so I still can't update.

navanchauhan commented 1 year ago

@johndoe0815 what device are you running this on?

johndoe0815 commented 1 year ago

@johndoe0815 what device are you running this on?

I run YunoHost on Proxmox on a Fujitsu Futro S740.

johndoe0815 commented 1 year ago

As I started to use tandoor outside of Yunohost in a separate docker container, I tried to uninstall and then freshly reinstall in Yunohost. Even that fresh install fails with invalid or unexpected token: https://paste.yunohost.org/raw/rojibebiwo

This is too unreliable to use "productively" :-(

aurore-finco commented 10 months ago

Hi! I have exactly the same problem, upgrading from 1.4.5 to current version (1.5.5). I restored 1.4.5 and it works. Here is the log from the upgrade: https://paste.yunohost.org/raw/alixoyozuv I run yunohost 11.2.4 on a Raspberry Pi 4B.

ericgaspar commented 1 month ago

should be fixed