YunoHost-Apps / trilium_ynh

Trilium package for YunoHost
https://github.com/zadam/trilium
GNU Affero General Public License v3.0
10 stars 8 forks source link

Desktop sync doesn't work #4

Closed maniackcrudelis closed 3 years ago

maniackcrudelis commented 3 years ago

Hi there

I've started working on a package for this app a few days ago, probably just before you did... So I did start from scratch...

Anyway, if it can help, I've a fully working package over there https://github.com/maniackcrudelis/trilium_ynh.

I've one issue though, and I'm interested to know if you managed to fix it yet. When synchronizing from a desktop client it fails when using the domain name but works with the IP and port. Looks like there's an issue around the nginx configuration.

If you manage to fix that issue, I'm interested to know how you did ;)

Jules-Bertholet commented 3 years ago

I never tested desktop sync, no clue if it works or not.

maniackcrudelis commented 3 years ago

Just to give you a heads up, the synchronization doesn't work for Trilium because of the SSO cookie, found the issue with the dev of Trilium. Failling to sync from desktop to a server #1822

And I opened an issue about it on YunoHost repo.

Jules-Bertholet commented 3 years ago

Good job on debugging this! If you find a way to fix the issue from within the app feel free to make a PR.

maniackcrudelis commented 3 years ago

The issue is fixed by the PR https://github.com/YunoHost/SSOwat/pull/182, no more cookie from YunoHost during the synchronization, it does work now. Nothing to do in nginx config to fix it, just to wait for the fix into a future release.