YunoHost-Apps / uptime-kuma_ynh

Uptime Kuma package for YunoHost
https://uptime.kuma.pet/
GNU Affero General Public License v3.0
12 stars 4 forks source link

NodeJS version change #82

Closed DunkieGaming closed 10 months ago

DunkieGaming commented 11 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

orhtej2 commented 11 months ago

Test update from previous version, if the upgrade script does not fully replace node_modules the app will likely fail to start.

ketsapiwiq commented 11 months ago

!testme

yunohost-bot commented 11 months ago

:carousel_horse: Test Badge

ketsapiwiq commented 11 months ago

Mmmh but I don't understand the root of this memory leak issue, it does work fine on other people's install. I don't see why it shouldn't be merged tho, provided the upgrade to this node v18 version does indeed work.