YunoHost-Apps / vaultwarden_ynh

Open source password management solutions for YunoHost
https://bitwarden.com/
GNU General Public License v3.0
59 stars 18 forks source link

Your app is level 0 #24

Closed maniackcrudelis closed 4 years ago

maniackcrudelis commented 4 years ago

Hi,

Your app doesn't work on our CI and is currently level 0. https://ci-apps.yunohost.org/ci/job/5756

Your app will be moved at 'notworking' status by the end of next week, on January, 4 if nothing is done before to make it work.

yalh76 commented 4 years ago

Currently working on it. Last OR:https://github.com/YunoHost-Apps/bitwarden_ynh/pull/23 was ok on my CI

kay0u commented 4 years ago

You should switch your app as working then :-)

yalh76 commented 4 years ago

I was waiting https://ci-apps.yunohost.org/ci/apps/bitwarden/ results before, but first package_check failed :/

Need to do more tests

yalh76 commented 4 years ago

Well, I have done a lot of package_check on bitwarden_ynh. All are ok and level7. But I still don't understand why ci-apps still fails.

Here are results from my CI image image

Here a result from a freshly installed package_check image

maniackcrudelis commented 4 years ago

You should try to use the --time argument on ynh_script_progression to see how much time the service take to start. And how much there is before the script end after that. I suspect something about that, the official CI isn't especially fast.

maniackcrudelis commented 4 years ago

https://github.com/YunoHost-Apps/bitwarden_ynh/pull/42/files#diff-44cb16c778719320333118c04d509a7cR169-R172 THIS IS NOT A SOLUTION !!!

Find and fix the issue !

maniackcrudelis commented 4 years ago

As the error is "failed to spawn thread", you should look about number of workers, which can be set (somewhere) for Rust. https://docs.rs/rocket/0.3.12/rocket/struct.Config.html#structfield.workers The repo you're using use the env variable ROCKET_WORKERS with docker (https://github.com/dani-garcia/bitwarden_rs/wiki/Changing-the-number-of-workers). Could be a lead.

yalh76 commented 4 years ago

Thanks a lot, I will try that.

yalh76 commented 4 years ago

Thanks for the help after implementing ROCKET_WORKERS and reducing to ROCKET_WORKERS=1 package_check is now ok. But I really don't know what will be the effect on production. We will see :)