The DNS method was hardcoded as "custom" in the cube file importer.
Therefore, when we import a cube file with empty DNS resolvers, it produces an error instead of using the default DNS resolvers from Yunohost.
Solution
I'm checking if the DNS resolvers from the cube file are empty, then I'm using the default DNS resolvers from Yunohost (dns_method = yunohost).
PR Status
[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)
Problem
The DNS method was hardcoded as "custom" in the cube file importer. Therefore, when we import a cube file with empty DNS resolvers, it produces an error instead of using the default DNS resolvers from Yunohost.
Solution
I'm checking if the DNS resolvers from the cube file are empty, then I'm using the default DNS resolvers from Yunohost (dns_method = yunohost).
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)