YunoHost-Apps / vpnclient_ynh

VPN Client app for YunoHost
GNU Affero General Public License v3.0
41 stars 25 forks source link

Fix run parts missing operand #111

Closed hidrarga closed 1 year ago

hidrarga commented 1 year ago

Problem

OpenVPN is sending arguments when running the down script. The problem is that run-parts can't handle these extra arguments, and then crashes…

Solution

I don't have a really clean solution, except creating a bash script that execute run-parts without these extra arguments

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

hidrarga commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower: Test Badge

hidrarga commented 1 year ago

Thanks!

Btw I'm thinking it would be nice to document this new run-script mechanism in doc/ADMIN.md if you have the energy for it 👍

That's a good idea, I'll do that in another PR though :)