CSRF on VPN configuration endpoint

YunoHost-Apps / vpnclient_ynh

VPN Client app for YunoHost

GNU Affero General Public License v3.0

41 stars 25 forks source link

CSRF on VPN configuration endpoint #43

Closed randomstuff closed 5 years ago

randomstuff commented 5 years ago

The VPN configuration endpointt (/vpnadmin/?/settings) is vulnerable to CSRF.

randomstuff commented 5 years ago

See https://github.com/sofadesign/limonade/issues/54

randomstuff commented 5 years ago

According to the tests I just did, this seems mitigates by SameSite=lax cookie setting on latest YunoHost. This is not available on all browsers however (but most evergreen browsers seem to be fine).

pitchum commented 5 years ago

Fix included in v1.3.0