search

YunoHost-Apps / vpnclient_ynh

VPN Client app for YunoHost
GNU Affero General Public License v3.0
41 stars 25 forks source link

Fix upgrade maybe :< #45

Closed alexAubin closed 5 years ago

alexAubin commented 5 years ago

One or two weeks ago we had an issue when trying to upgrade vpnclient ... Turns out the error was caused by the upgrade script calling the install script, which does not source helpers if the upgrade is being ran ... But that doesn't make sense because the next thing being done is calling ynh_webpath_register which is an helper.

In fact, what should not be done is running ynh_webpath_register during the upgrade as the path i already registered

(I dunno how this compares to pitchum's more extensive work on the topic, maybe this PR isnt relevant or less relevant than his ;P)

alexAubin commented 5 years ago

Warning : I didn't test it tho ...

zamentur commented 5 years ago

I have tested on my own internetcube...