search

YunoHost-Apps / vpnclient_ynh

VPN Client app for YunoHost
GNU Affero General Public License v3.0
41 stars 25 forks source link

Testing #80

Closed zamentur closed 2 years ago

zamentur commented 3 years ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

alexAubin commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: Test Badge

hidrarga commented 2 years ago

Oy ! I just tested an upgrade of the vpnclient from the testing branch of Yunohost (4.3.1.3), and everything is looking fine so far, except that you forget to remove the php-fpm config of the app. Thus, when the php-fpm service restarts, it fails miserably :p

So I think you should add a line in the upgrade script to remove that config file ^^

alexAubin commented 2 years ago

!testme

yunohost-bot commented 2 years ago

May the CI gods be with you! Test Badge

alexAubin commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: Test Badge