Apply last example_ynh - Githubissues

YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost

https://www.wallabag.org/

GNU Affero General Public License v3.0

62 stars 14 forks source link

Apply last example_ynh #118

Closed lapineige closed 2 years ago

lapineige commented 2 years ago

Apply last example_ynh
Cleanup backup
Update Readme : add templates #120

PR Status

[x] Code finished.
[ ] Tested with Package_check.
[x] Fix or enhancement tested.
[x] Upgrade from last version tested.
[x] Can be reviewed and tested.

Validation

Minor decision

Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
CI succeeded :
Please replace '-NUM-' in this link by the PR number.
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

yalh76 commented 2 years ago

I propose to first merge that PR and later do 2.4.2 upgrade

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:v:

lapineige commented 2 years ago

I propose to first merge that PR and later do 2.4.2 upgrade

That's also what I had in mind. It's safer this way :)

We will need #120.

yalh76 commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:stuck_out_tongue_winking_eye:

lapineige commented 2 years ago

~Well, another CI for zero code change ? 😅~ My bad, I missed your commits.

Upgrade tested successfully 🙂

yalh76 commented 2 years ago

~Well, another CI for zero code change ? 😅~

As we have seen with pixelfed, better to have too much CI tests than not enough :p

My bad, I missed your commits.

Upgrade tested successfully 🙂

Can we merge ?