2.4.2

[lapineige]

Problem

• Wallabag 2.4.2 is available https://github.com/wallabag/wallabag/releases/tag/2.4.2

Solution

• [x] Update to 2.4.2
• [ ] Update check_process file : I need help to do that, I don't understand how this works 😅
• [x] Let's merge #118 first
• [ ] Maybe we need to fix PHP 5 specific stuff first ?

PR Status

• [ ] Code finished.
• [ ] Tested with Package_check.
• [ ] Fix or enhancement tested.
• [ ] Upgrade from last version tested.
• [ ] Can be reviewed and tested.

Validation

---

Minor decision

• Upgrade previous version :
• [ ] Code review :
• [ ] Approval (LGTM) :
• [ ] Approval (LGTM) :
• CI succeeded :
  Please replace '-NUM-' in this link by the PR number.
  When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

[lapineige]

I'm creating that PR as it's very quickly done (we will have it for later :) and to document what needs to be done.

In particular:

Maybe we need to fix PHP 5 specific stuff first ?

@yalh76 do you thing we should do that before upgrading to 2.4.2, as @ericgaspar did in its PR ? (#109) Considering 2.4.2 seems to introduce some strange bug, I believe it's better to do it step by step.

[yalh76]

!testme

[yunohost-bot]

Alrighty!

[yalh76]

If there are some issues with 2.4.2, maybe first upgrading to 2.4.0 to have bullseye compatibility, and later 2.4.1 and at the end 2.4.2

[lapineige]

Well, I will give it a try (using CI), but if I remember well there where some important bugs in 2.4 that should be corrected in 2.4.2

edit: wait : don't we need to remove any php5 specific stuff first ? Might it be the issue we encounter here ?

[yalh76]

edit: wait : don't we need to remove any php5 specific stuff first ? Might it be the issue we encounter here ?

I dont see any php5 specific stuff

[yalh76]

Seems that 2.4.2 wasn't from testing ... so redoing it ...

[yalh76]

done it at:

• 121

• 122

• 123

[lapineige]

What are we supposed to do with all those PR, as all fails (in CI) ? :sweat_smile:

[yalh76]

What are we supposed to do with all those PR, as all fails (in CI) ? 😅

find a way to make them all works and decide which one we will merge to testing ;)

[yalh76]

Which version, do you want to merge to testing ?

[lapineige]

I think I want to check if I can upgrade to 2.4.3, and if other people with that know bug can too… I hope it will fix that mess 😅

[yalh76]

OK then, I let you decide, merge and close the PR we no more need ;)