YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost
https://www.wallabag.org/
GNU Affero General Public License v3.0
62 stars 14 forks source link

Drop new constraint before creating it to avoid existing constraint i… #131

Closed nicofrand closed 2 years ago

lapineige commented 2 years ago

I don't get what's the goal and what this is doing 😅 #SQLnoob Oh ok, now I see : https://github.com/YunoHost-Apps/wallabag2_ynh/pull/129#issuecomment-1074858073

Yet I am not able to judge if that's a good way to do it.

nicofrand commented 2 years ago

It simply deletes the keys before creating them (in case they already exist for newer versions) to avoid errors.

Le 22 mars 2022 21:21:18 lapineige @.***> a écrit :

I don't get what's the goal and what this is doing 😅 #SQLnoob — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

lapineige commented 2 years ago

And what if they already exists ?

nicofrand commented 2 years ago

Like I said: it first removes it and then recreates it

lapineige commented 2 years ago

Sorry ! What if they do not exist already ? Will it fail ?

nicofrand commented 2 years ago

No, it creates them

lapineige commented 2 years ago

Ok, then let's try it :)