YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost
https://www.wallabag.org/
GNU Affero General Public License v3.0
62 stars 14 forks source link

Specify PHP version in every calls #132

Closed tituspijean closed 2 years ago

tituspijean commented 2 years ago

We should set the PHP version instead of being exposed to bug if YNH_DEFAULT_PHP_VERSION changes. Moreover, the documentation says they are not sure if PHP 7.4 is compatible.

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

tituspijean commented 2 years ago

!gogogadgetotitus

yunohost-bot commented 2 years ago

At your service! Test Badge

lapineige commented 2 years ago

Well it's using php7.4 by default right now and it's working well as far as we know :thinking:

tituspijean commented 2 years ago

There's a thread in French on the forum (https://forum.yunohost.org/t/wallabag-refuse-de-sinstaller/19316) that brought me to open this PR to test it out, but I see you've already answered to it. :)


Feel free to change the phpversion I chose 7.3 a bit randomly.

lapineige commented 2 years ago

Yeah that is a good thing anyway to control which version is used 🙂, I was not criticizing that :)

Feel free to change the phpversion I chose 7.3 a bit randomly.

Well as it is already 7.4 I'm not sure it's a good idea to revert to 7.4… Just in case, @yalh76 what is your opinion on this ?

lapineige commented 2 years ago

CI seems to agree with php7.4 😄

lapineige commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: Test Badge

lapineige commented 2 years ago

Wow there is a strange bug…

In XmlUtils.php line 50: INFO DEBUG - INFO WARNING - Extension DOM is required.

tituspijean commented 2 years ago

!testme

yunohost-bot commented 2 years ago

Meow :cat2: Test Badge

lapineige commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:rocket: Test Badge

lapineige commented 2 years ago

I don't understand if the issue raised by CI during upgrade from previous version are real trouble of just some CI artefacts… what do you think ? Can we merge ?

lapineige commented 2 years ago

@tituspijean what do you think ?

lapineige commented 2 years ago

PHP 7.4 is the minimum in Wallabag 2.5, so let's keep it already :)

tituspijean commented 2 years ago

Oops sorry I missed your ping. let's see if everything works out in testing :)