search

YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost
https://www.wallabag.org/
GNU Affero General Public License v3.0
62 stars 14 forks source link

Upgrade database scheme #133

Open nicofrand opened 2 years ago

nicofrand commented 2 years ago

Problem

Pre-2018 installation had a bad database scheme. This should fix it partly, and allow them to upgrade to wallabag 2.4.x. See : https://github.com/YunoHost-Apps/wallabag2_ynh/pull/125

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

nicofrand commented 2 years ago

!testme

nicofrand commented 2 years ago

@lapineige can you !testme please :p?

I tested on my server, it upgrades to 2.4.3 like a charm.

lapineige commented 2 years ago

!testme

yunohost-bot commented 2 years ago

:sunflower: Test Badge

lapineige commented 2 years ago

@lapineige can you !testme please :p?

Oh, I didn't know there were some restricted right for that CI thing…

I tested on my server, it upgrades to 2.4.3 like a charm.

:tada:

nicofrand commented 2 years ago

Meh, still failing in the CI. It all depends on which migrations were already applied I guess. I give up, if needed people can always use this branch to upgrade and then upgrade to any further version.

lapineige commented 2 years ago

Thanks anyway for all your work, at least it's documented somewhere and maybe usable to migrate without doing all the SQL stuff by oneself (but instead one can use this branch).

I'll keep it open for a while in case someone want to help :slightly_smiling_face:

Limezy commented 2 years ago

OK... So now I understand why my wallabag, installed in 2017, was failing upgrades... Shall I start migrating my db using this PR, and then upgrade using the standard chanel ?

EDIT : It worked !

lapineige commented 2 years ago

Great !

Salamandar commented 6 months ago

Is it OK for you to replace this PR with #129 ? Although it looks like the sql code is not identical…

lapineige commented 6 months ago

I don't know. It was here to help in some very special case for some upgrade/migration purpose. Nobody posted feedback on this for 2 years.

I guess it's not really used anymore, and I wouldn't bother merging this until someone actually complains about it not being compatible. I'd keep it as a stale PR.