Fix PHP dependencies (fixes #140)

[JimboJoe]

Problem

• 140

Solution

• And how do you fix that problem

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[JimboJoe]

!testme

[yunohost-bot]

:carousel_horse:

[lapineige]

We might have more issue with php dependencies #141

[lapineige]

Also I'm unsure if we should merge this to testing (with version 2.5) or master directly, as a quick fix.

On one side it would be cool to provide a newer version right away, on the other one, I fear that this could break more upgrades…

[lapineige]

The upgrade issue that we see here in the CI is found in people installations too : #141

php7.4-cli : Depends: php7.4-opcache but it is not going to be installed
 Depends: php7.4-readline but it is not going to be installed
 Depends: libpcre2-8-0 (>= 10.38) but 10.32-5 is to be installed
php7.4-fpm : Depends: php7.4-opcache but it is not going to be installed
 Depends: libpcre2-8-0 (>= 10.38) but 10.32-5 is to be installed
php7.4-intl : Depends: libicu65 (>= 65.1-1~) but it is not going to be installed
php7.4-redis : Depends: php7.4-igbinary but it is not going to be installed
 Breaks: php-redis (< 5.3.7+4.3.0-1+0~20220330.42+debian10~1.gbp6fe8b7~)

But not everyone face it.

I don't get it… Some debian installs have no dependency issue but other have it ?

ping @YunoHost-Apps/apps-group, I'm lost and I need a little help to diagnose this issue :sweat_smile:

[lapineige]

I can reproduce this issue while being already in 2.4.3…

  php7.4-cli : Depends: php7.4-opcache but it is not going to be installed
               Depends: php7.4-readline but it is not going to be installed
  php7.4-fpm : Depends: php7.4-opcache but it is not going to be installed
  php7.4-redis : Depends: php7.4-igbinary but it is not going to be installed
                 Breaks: php-redis (< 5.3.7+4.3.0-1+0~20220330.42+debian10~1.gbp6fe8b7~)

[lapineige]

Also I'm unsure if we should merge this to testing (with version 2.5) or master directly, as a quick fix.

As upgrade seems to be blocked for some installations #141, I suggest we fix upgrade that succeed but gave a broken app at the end (#140).

Hence let's merge this to master first.

[lapineige]

Wow ok I forgot that you probably forked testing to create this PR… @JimboJoe could you please make a new PR from current master and commit theses changes in this new PR ?

[JimboJoe]

I'm sorry I'm not sure I will find time on the very short term to put into this...

[lapineige]

On, then I'll do it directly in master :)

[Gofannon]

Some other dependencies might be needed, the list is long : https://doc.wallabag.org/en/admin/installation/requirements.html#php-extensions

[lapineige]

I don't know, a lot of them where not listed in this package for years without reported issues as far as I know, I suppose they come with other ones or by default, hence are not directly needed ? :thinking:

[lapineige]

https://forum.yunohost.org/t/mise-a-jour-impossible-de-wallabag/20485/15

This branch seems to fix both #140 and #141. If we can confirm that's the case, then I fix I'll merge this right away, as upgrade is broken for many people (at the very least all using Nextcloud too).

[lapineige]

!bullseyetestme

[yunohost-bot]

[Bullseye :horse:] Meow :cat2:

[lapineige]

Install successfully tested on my side

[lapineige]

https://forum.yunohost.org/t/mise-a-jour-impossible-de-wallabag/20485/15

This branch seems to fix both #140 and #141. If we can confirm that's the case, then I fix I'll merge this right away, as upgrade is broken for many people (at the very least all using Nextcloud too).

Confirmed : https://forum.yunohost.org/t/mise-a-jour-impossible-de-wallabag/20485/18

So this PR and #139 should fix both #140 and #141.

Hence I'm merging it right away.