2.5.4

[lapineige]

• Wallabag 2.5.3 https://github.com/wallabag/wallabag/releases/tag/2.5.3 has been released. It a security fix upgrade, but not an urgent one (no breach from outside or similar), so I will merge this as soon as the continuous integration result is ready.

• Then Wallabag 2.5.4, security release again : https://github.com/wallabag/wallabag/releases/tag/2.5.4

PR Status

• [ ] Code finished and ready to be reviewed/tested
• [ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

[lapineige]

!testme

[yunohost-bot]

Meow :cat2:

[lapineige]

ERROR 500: Internal Server Error.

I'm lost…

[nicosomb]

Maybe because https://static.wallabag.org/releases/wallabag-release-2.5.3.tar.gz was unavailable. I just uploaded the file on our server.

[lapineige]

Thanks for the feedback. I'll try again.

[lapineige]

!testme

[yunohost-bot]

Fingers crossed!

[lapineige]

!testme

[yunohost-bot]

:carousel_horse:

[yunohost-bot]

Alrighty!

[lapineige]

240312 INFO DEBUG - Hunk #1 succeeded at 176 (offset 133 lines).
240313 INFO DEBUG - + for p in $patches_folder/${source_id}-*.patch
240313 INFO DEBUG - + echo /var/cache/yunohost/app_tmp_work_dirs/app_qcyjiof6/app_folder/sources/patches/app-01-logout-success-handler.patch
240313 INFO DEBUG - /var/cache/yunohost/app_tmp_work_dirs/app_qcyjiof6/app_folder/sources/patches/app-01-logout-success-handler.patch
240313 INFO DEBUG - + patch --strip=1
240314 INFO DEBUG - patching file app/config/security.yml
240314 INFO DEBUG - Hunk #1 succeeded at 63 with fuzz 2 (offset 1 line).
240314 INFO DEBUG - patching file app/config/services.yml
240314 INFO DEBUG - Hunk #1 succeeded at 176 (offset 133 lines).
240315 INFO DEBUG - patching file src/Wallabag/YunoHostBundle/Security/LogoutSuccessHandler.php
240315 INFO DEBUG - + for p in $patches_folder/${source_id}-*.patch
240315 INFO DEBUG - + echo /var/cache/yunohost/app_tmp_work_dirs/app_qcyjiof6/app_folder/sources/patches/app-02-oauth-workaround.patch
240315 INFO DEBUG - /var/cache/yunohost/app_tmp_work_dirs/app_qcyjiof6/app_folder/sources/patches/app-02-oauth-workaround.patch
240316 INFO DEBUG - + patch --strip=1
240316 INFO DEBUG - patching file vendor/friendsofsymfony/oauth-server-bundle/Storage/OAuthStorage.php
240316 INFO DEBUG - Hunk #1 FAILED at 166.
240316 INFO DEBUG - 1 out of 1 hunk FAILED -- saving rejects to file vendor/friendsofsymfony/oauth-server-bundle/Storage/OAuthStorage.php.rej
240317 INFO DEBUG - + ynh_die '--message=Unable to apply patches'
240317 INFO WARNING - Unable to apply patches
240317 INFO DEBUG - + ynh_exit_properly

We need to fix that patches issue as soon as possible (this is a security update). I don't really know how to debug this.

[lapineige]

!testme

[yunohost-bot]

May the CI gods be with you!

[yunohost-bot]

:v:

[nicosomb]

@lapineige the gz file was not available. Could you retry?

[lapineige]

Yeah I realised that afterwards. I restarted it.

[lapineige]

247214 WARNING E: Failed to fetch http://deb.debian.org/debian/pool/main/t/tidy-html5/libtidy5deb1_5.6.0-11_amd64.deb Connection timed out [IP: 199.232.190.132 80] 247215 WARNING E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? 251239 WARNING The following packages have unmet dependencies: 251240 WARNING php7.4-redis : Depends: php7.4-igbinary 251241 WARNING php7.4-tidy : Depends: php7.4-common (= 1:7.4.33-3+0~20230113.76+debian11~1.gbp83f72b) but 7.4.33-1+deb11u1 is to be installed 251241 WARNING Depends: libtidy5deb1 (>= 1:5.2.0) but it is not going to be installed 251299 WARNING Unable to install dependencies

What's going on 🤔

[lapineige]

I can download that file, that's a CI issue...

[nicosomb]

ok, tell me if you need help from wallabag side.

[lapineige]

On another CI https://yunorunner.travelpandas.eu/ci/job/17 (thanks @oufmilo !):

Package linter: OK (3 possible improvements) Install (root): OK Install (subdir): OK Install (multi): OK Backup/restore: OK Upgrade: OK Upgrade (f75d58cb): fail Upgrade (2e20b8f9): fail Upgrade (4da53256): fail Change url: OK

Upgrade from old version fails. I don't understand why this issue is triggered :

72552 INFO WARNING - PHP Fatal error: Cannot redeclare mb_str_split() in /var/www/wallabag2/vendor/wallabag/php-mobi/MOBIClass/RecordFactory.php on line 119

And if this as any implication that should prevent us from merging this...

[lapineige]

Upgrade done on my side, works like a charm :)

[lapineige]

Upgrade from old version fails. I don't understand why this issue is triggered :

72552 INFO WARNING - PHP Fatal error: Cannot redeclare mb_str_split() in /var/www/wallabag2/vendor/wallabag/php-mobi/MOBIClass/RecordFactory.php on line 119

And if this as any implication that should prevent us from merging this...

Seems related to that issue : https://github.com/wallabag/wallabag/issues/4271

However in my case upgrading from previous version wasn't an issue. As it is a security update, I'm merging to testing right away, and waiting for more testers or feedback from Wallabag team about this issue to know if we can merge for real.