YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost
https://www.wallabag.org/
GNU Affero General Public License v3.0
62 stars 14 forks source link

Version 2 #168

Closed ericgaspar closed 1 year ago

ericgaspar commented 1 year ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:rocket: Test Badge

lapineige commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:rocket: Test Badge

lapineige commented 1 year ago

!testme

yunohost-bot commented 1 year ago

Meow :cat2: Test Badge

lapineige commented 1 year ago

I'm merging #166 as it contains important security patches (← php upgrade). This v2 will take more time for manual testing.

lapineige commented 1 year ago

Manual upgrade went fine in my case, but CI is unhappy.

lapineige commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:rocket: Test Badge

lapineige commented 1 year ago

34063 WARNING In AbstractMySQLDriver.php line 128: 34067 WARNING An exception occurred in driver: SQLSTATE[HY000] [1698] Access denied for u 34068 WARNING ser 'root'@'localhost' 34080 WARNING In Exception.php line 18: 34081 WARNING SQLSTATE[HY000] [1698] Access denied for user 'root'@'localhost' 34081 WARNING In PDOConnection.php line 40: 34081 WARNING SQLSTATE[HY000] [1698] Access denied for user 'root'@'localhost'

I don't get it…

tituspijean commented 1 year ago

It looks like the command sudo -u wallabag2 php7.4 /var/www/wallabag2/bin/console ... still tries to run a MySQL command as root, despite the paremeters.yml file being filled. That is not normal.

lapineige commented 1 year ago

The use of php7.4 is also an issue, I configured php8.1 🤔

ericgaspar commented 1 year ago

!testme

yunohost-bot commented 1 year ago

:sunflower: Test Badge

lapineige commented 1 year ago

Why did you close it ? :thinking:

171 will now "superseded" it, right, but it was good to go step by step, the work on this v2 was very appreciated :smiley:

lapineige commented 1 year ago

It looks like the command sudo -u wallabag2 php7.4 /var/www/wallabag2/bin/console ... still tries to run a MySQL command as root, despite the paremeters.yml file being filled. That is not normal.

It was a typo, an extra space, fixed in #171