search

YunoHost-Apps / wallabag2_ynh

Wallabag v2 package for YunoHost
https://www.wallabag.org/
GNU Affero General Public License v3.0
63 stars 13 forks source link

Testing - packagingv2 - 2.6 #191

Closed Salamandar closed 4 months ago

Salamandar commented 4 months ago

Problem

Solution

PR Status

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige commented 4 months ago

!testme

yunohost-bot commented 4 months ago

Alrighty! Test Badge

lapineige commented 4 months ago

This is a big PR, so I think it requires a lot of manual testing. Testers welcome ! Just wait for the test to be complete, just in case ;)

lapineige commented 4 months ago

Does the CI test update from <2.4.0 ? It's only a special corner case that's handled by the PR you merged, so I would like to make sure it doesn't fail on the other situations.

lapineige commented 4 months ago 
16685 INFO DEBUG - + local current_version=2.5.4~ynh2
16685 INFO DEBUG - + [[ ! 2.4 =~ ~ynh ]]
16685 INFO DEBUG - + ynh_die '--message=Invalid argument for version.'
16685 INFO WARNING - Invalid argument for version

@Salamandar looks like the PR wasn't working correctly after all 😄

Salamandar commented 4 months ago

@lapineige I fixed the upgrade, and added a test_upgrade_from 2.3.8.

Salamandar commented 4 months ago

@lapineige I fixed the upgrade, and added a test_upgrade_from 2.3.8.

Well initial install doesn't work, so removing it.

Salamandar commented 4 months ago

@lapineige this PR is ready for me. Merge when you feel like it :)

PS: I also asked my brother to test upgrade with this PR, i'll post here the results.