V2.6 - Githubissues

Salamandar commented 4 months ago

Problem

Description of why you made this PR

Solution

And how do you fix that problem

PR Status

[ ] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige commented 4 months ago

!testme

yunohost-bot commented 4 months ago

:rocket:

ericgaspar commented 2 months ago

!testme

yunohost-bot commented 2 months ago

:worm:

yunohost-bot commented 2 months ago

Alrighty!

mcint commented 2 months ago

I've manually debugged and fixed other plugin upgrades, errors, on my own system.

Many follow a pattern, I'm unfamiliar with these errors -- pasting here for attention. I guess the step of help that would really move the needle is building myself a test instance and getting the update to work. Can I run it in docker?

60788 INFO DEBUG - + sudo -u wallabag2 php8.2 /var/www/wallabag2/bin/console --no-interaction --env=prod wallabag:install 60788 INFO DEBUG - PHP Warning: require(/var/www/wallabag2/bin/../vendor/autoload.php): Failed to open stream: No such file or directory in /var/www/wallabag2/bin/console on line 15 60788 INFO DEBUG - PHP Fatal error: Uncaught Error: Failed opening required '/var/www/wallabag2/bin/../vendor/autoload.php' (include_path='.:/usr/share/php') in /var/www/wallabag2/bin/console:15

More complete trace, from (install as) root test case.

57575 INFO [+++++++++++++.......] > Setting up source files...
58470 WARNING Packagers /!\ patch /var/cache/yunohost/app_tmp_work_dirs/app_6_q75vno/app_folder/sources/patches/main-02-oauth-workaround.patch failed to apply
58545 INFO [#############++.....] > Adding wallabag2's configuration files...
60766 ERROR Unable to install wallabag2: An error occurred inside the app installation script
60766 INFO The operation 'Install the 'wallabag2' app' could not be completed. Please share the full log of this operation using the command 'yunohost log share 20240513-061007-app_install-wallabag2' to get help
60786 WARNING Here's an extract of the logs before the crash. It might help debugging the error:
60787 INFO DEBUG - + cat /var/www/wallabag2/app/config/parameters.yml
60787 INFO DEBUG - + '[' -n '' ']'
60787 INFO DEBUG - + unset backup_file_checksum
60787 INFO DEBUG - + chmod 600 /var/www/wallabag2/app/config/parameters.yml
60787 INFO DEBUG - + chown wallabag2:www-data /var/www/wallabag2/app/config/parameters.yml
60787 INFO DEBUG - + php_exec=("php$phpversion" "$install_dir/bin/console" --no-interaction --env=prod)
60787 INFO DEBUG - + ynh_exec_warn_less ynh_exec_as wallabag2 php8.2 /var/www/wallabag2/bin/console --no-interaction --env=prod wallabag:install
60787 INFO DEBUG - + [[ 7 -eq 1 ]]
60787 INFO DEBUG - + ynh_exec_as wallabag2 php8.2 /var/www/wallabag2/bin/console --no-interaction --env=prod wallabag:install
60788 INFO DEBUG - + local user=wallabag2
60788 INFO DEBUG - + shift 1
60788 INFO DEBUG - ++ whoami
60788 INFO DEBUG - + [[ wallabag2 = root ]]
60788 INFO DEBUG - + sudo -u wallabag2 php8.2 /var/www/wallabag2/bin/console --no-interaction --env=prod wallabag:install
60788 INFO DEBUG - PHP Warning:  require(/var/www/wallabag2/bin/../vendor/autoload.php): Failed to open stream: No such file or directory in /var/www/wallabag2/bin/console on line 15
60788 INFO DEBUG - PHP Fatal error:  Uncaught Error: Failed opening required '/var/www/wallabag2/bin/../vendor/autoload.php' (include_path='.:/usr/share/php') in /var/www/wallabag2/bin/console:15
60788 INFO DEBUG - Stack trace:
60788 INFO DEBUG - #0 {main}
60788 INFO DEBUG -   thrown in /var/www/wallabag2/bin/console on line 15
60789 INFO DEBUG - + ynh_exit_properly
60805 ERROR The installation of wallabag2 failed, but was not cleaned up as requested by --no-remove-on-failure.
Error: Installation failed.
Peak RAM usage during this test: 237MB
RAM usage diff after test: 70MB
Disk usage diff after test: 409.8MB

--- FAIL ---

Underinformed hunches

I notice the false-case equality checks

60787 INFO DEBUG - + [[ 7 -eq 1 ]]
54486 INFO DEBUG - + [[ wallabag2 = root ]] -- despite checking for root, present in all install test cases: root, subdir (in summary, sub-path inline name), private, multi

I've fixed, a few times, missing or differing libraries and functions, in upgrading php from 7.4 to 8.*.

Motivation

The carrot I'm chasing, in case it interests you too, is correct handling of news.ycombinator.com, thanks to pulling in updates to extraction logic, in fivefilters/ftr-site-config/pull/1275 and fivefilters/ftr-site-config/pull/1276 for this comments site, tracked in wallabag/wallbag#4116. This update will allow wallabag to save the actual content of comments from the site, instead of the comment-tree structure without text of comments.

Once it updates, I'll wish I could bulk trigger re-extraction of comments on that domain.

lapineige commented 2 months ago

Can I run it in docker?

Running a Yunohost instance inside Docker, as far as I know, is quite tricky. It's easier to try a virtualisation tool.

Salamandar commented 1 month ago

Superseeded by automatic pr at #203 .

YunoHost-Apps / wallabag2_ynh