add allow_email parameter

YunoHost-Apps / wordpress_ynh

WordPress package for YunoHost

https://wordpress.org/

GNU General Public License v3.0

26 stars 30 forks source link

add allow_email parameter #233

Open lapineige opened 10 months ago

lapineige commented 10 months ago

It's needed for signed emails.

PR Status

[x] Code finished and ready to be reviewed/tested
[ ] The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

lapineige commented 10 months ago

!testme

yunohost-bot commented 10 months ago

Fingers crossed!

alexAubin commented 10 months ago

cf https://github.com/YunoHost-Apps/wordpress_ynh/pull/230#discussion_r1412851429

lapineige commented 10 months ago

It's needed for some extensions that send email, so let's keep it ?

alexAubin commented 10 months ago

To me that just gives the false impression that the app integrates properly with email, which it doesnt if this ain't actually used ... Or if we can't configure it automatically, we should at least properly document it how to manually configure it in ADMIN.md maybe ...

lapineige commented 10 months ago

Or if we can't configure it automatically, we should at least properly document it how to manually configure it in ADMIN.md maybe ...

Well then this is the TODO here 🙂