ligne 142 : [: -eq : opérateur unaire attendu

ewilly commented 6 years ago

I dont really understand why but ynh_app_setting_get zerobin is_public give me an empty result even zerobin was up to date according to commit in official.json. Relevent console output is :

+ '[' -eq 1 ']'
Attention : ./upgrade: ligne 142 : [: -eq : opérateur unaire attendu
+ systemctl reload nginx
+ ynh_exit_properly
+ exit_code=0
+ '[' 0 -eq 0 ']'
+ exit 0
Succès ! zerobin a été mis à jour
Succès ! La configuration de SSOwat a été générée
Succès ! Mise à jour terminée

Problem

Description of why you made this PR

Solution

And how you fix that

PR Status

Work NOT finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

[ ] Upgrade previous version :
[ ] Code review :
[ ] Approval (LGTM) :
[ ] Approval (LGTM) :
[ ] CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

maniackcrudelis commented 6 years ago

The current stable version doesn't store is_public in the config file. That's why the upgrade script can't find anything.

To fix that, it shall detect "unprotected_uris" in this config file and set is_public accordingly to that.

maniackcrudelis commented 6 years ago

Replaced by https://github.com/YunoHost-Apps/zerobin_ynh/pull/25 which fixed the blank value of is_public.

YunoHost-Apps / zerobin_ynh