Fix empty is_public - Githubissues

YunoHost-Apps / zerobin_ynh

PrivateBin package for YunoHost

https://privatebin.info

GNU General Public License v3.0

11 stars 12 forks source link

Fix empty is_public #25

Closed maniackcrudelis closed 6 years ago

maniackcrudelis commented 6 years ago

Problem

Following https://github.com/YunoHost-Apps/zerobin_ynh/pull/23 The stable version doesn't store the value of is_public. In case of upgrade, the upgrade script can't know is the app is public or not.

Solution

If is_public is empty, try to find unprotected_uris in the config file to know ifg the app is public or not. Then set and store the value.

PR Status

Work finished. Package_check, basic tests and upgrade from last version OK.
Could be reviewed and tested.

Validation

Minor decision

[x] Upgrade previous version : JimboJoe
[x] Code review : JimboJoe
[x] Approval (LGTM) : JimboJoe
[ ] Approval (LGTM) :
[x] CI succeeded :
When the PR is mark as ready to merge, you have to wait for 3 days before really merge it.

maniackcrudelis commented 6 years ago

@YunoHost-Apps/apps-group

maniackcrudelis commented 6 years ago

Let's merge in 3 days