YunoHost / issues

General issue tracker for the YunoHost project
72 stars 8 forks source link

Diagnostic fails after adding an extra TXT record #1951

Open spctrlth opened 2 years ago

spctrlth commented 2 years ago

Describe the bug

I added it an extra TXT record to my main domain because I can easily query that and needed a place to store some information. I assume I'm allowed to do that because I assume TXT records are just free form and you're allowed to have multiple each for their own purpose.

Obviously I kept the records ynh expects to find, however, the automatic diagnostic now fails because ynh doesn't expect other TXT records to be there.

For now I'll just add it to a subdomain ynh doesn't know about, so it's not a big deal, but it looks like a bug, so I wanted to report it.

Context

To reproduce

  1. Have a domain with the correct DNS records which you control. The records include a "v=spf1 a mx -all".
  2. Add another TXT record to the domain
  3. Run the diagnostics

Expected behavior

I expect the diagnostics to succeed because the relevant record "v=spf1 a mx -all" is still there. I assume it shouldn't matter that an extra, non-related, TXT record is also there.

Logs

What I get from the automatic diagnostic:

[WARNING] Some DNS records are missing or incorrect for domain ilja.space (category mail)
  - Please check the documentation at https://yunohost.org/dns_config if you need help about configuring DNS records.
  - The following DNS record does not seem to follow the recommended configuration:
    Type: TXT
    Name: @
    Current value: ['"v=spf1 a mx -all"', '"onion=dgiu2kasdlelcuawn3moeayox32e6ouefp6w3oqwc2faluwmsubhb4yd.onion"']
    Expected value: "v=spf1 a mx -all"

When I dig for the TXT records:

$ dig ilja.space -t txt +short
"v=spf1 a mx -all"
"onion=dgiu2kasdlelcuawn3moeayox32e6ouefp6w3oqwc2faluwmsubhb4yd.onion"
alexAubin commented 2 years ago

Similar to https://github.com/YunoHost/issues/issues/1621