Bookworm: ideally, custom logos should not be stored as base64 but as separate files

YunoHost / issues

General issue tracker for the YunoHost project

71 stars 8 forks source link

Bookworm: ideally, custom logos should not be stored as base64 but as separate files #2322

Closed alexAubin closed 4 months ago

alexAubin commented 5 months ago

Currently custom portal logos are stored as base64 in the corresponding domain config, but that means the .json payload is huge for something that should be cached ... We should really explore what nginx trickeries we can use to route the request to the appropriate file somehow (though paying attention to classic caching issues eg 'what if the old logo is cached but you changed the logo')

alexAubin commented 4 months ago

Fixed in https://github.com/YunoHost/yunohost/commit/c77d05e69344643b44e735e7bce11ca2b2eb7dd7 and https://github.com/YunoHost/yunohost-portal/commit/3fd3e248919413995b1b65c3cb936deca3f40171 (though i probably broke the SVG case)