YunoHost / issues

General issue tracker for the YunoHost project
72 stars 8 forks source link

Re-use the DNS Authentication token for all domains that are part of the same 2LD #2345

Open silverhook opened 8 months ago

silverhook commented 8 months ago

I have a second-level domain registered with Gandi.

I use several third-level domains of that 2LD on my YuNoHost.

It is annoying that I need to re-enter the DNS Authentication token for every new 3LD I create in YuNoHost, since on Gandi’s DNS these are just part of the same 2LD anyway.

I propose to re-use the DNS Authentication token for all 3LD (and 4LD, …) created in YuNoHost that are part of the same 2LD.

(caveat: a select few domains can be registered as 3LD though … e.g. .name, so it would need to take this edge-case into account)

zamentur commented 8 months ago

(caveat: a select few domains can be registered as 3LD though … e.g. .name, so it would need to take this edge-case into account)

Not sure to understand this part.

silverhook commented 8 months ago

(caveat: a select few domains can be registered as 3LD though … e.g. .name, so it would need to take this edge-case into account)

Not sure to understand this part.

Originally it was only possible to register .name domains in the form of {$firstname}.{$lastname}.name, so at least when it comes to this TLD there are domain names that are registered as third-level domains (and second-level domains are therefore reserved/non-registrable).

As a concrete example, I have the domain matija.suklje.name registered. I don’t (and cannot) have suklje.name registered. So in this specific case if I registered (on e.g. Gandi) xxxxx.suklje.name and added it to YunoHost, it would be treated as a completely separate domain (also from the registar/registry’s side), and not just a subdomain, with its own contract, DNS entries and all.

But that’s an edge case, I know.

https://en.wikipedia.org/wiki/.name

(let me know if that explains it well enough)

zamentur commented 8 months ago

Ok i was not aware of this kind of domain. I am not sure we manage this kind of things correctly in the diagnosis https://github.com/YunoHost/yunohost/blob/734e9102418faf5ddeba1338443c93a919f1ca2b/src/diagnosers/12-dnsrecords.py#L66 On my side i understand it is different domains so the registrar and API could be different...

OniriCorpe commented 8 months ago

I am not sure we manage this kind of things correctly in the diagnosis YunoHost/yunohost@734e910/src/diagnosers/12-dnsrecords.py#L66

cf: https://github.com/YunoHost/issues/issues/2346

silverhook commented 8 months ago

As I said, the 3LD .name domains are very much an edge case, so if the token can be shared for “normal” domains, that would already be very nice :)