Domain reminder does not work in certain cases (registered 2LD where only 3LD are used; registered 3LD)

silverhook commented 7 months ago

Describe the bug

/yunohost/admin/#/diagnosis provides a really nice domain name expiry reminder, but I ran into two occasions where it does not work, but it should:

a third-level .name domain name – yes, this was a weird special feature of .name TLD back when it was created, I unfortunately, have one of those – for this it complains that The domain {$2LD} doesn't exist in WHOIS database or is expired! – which is technically true, but not the domain I am concerned about, I care about the registered 3LD
I have a second-level .at domain name registered which is expiring in 15 days from now, and use several 3LD under it on my YuNoHost, but I have not received a reminder about its expiry yet

Context

Hardware: Old laptop or computer
YunoHost version: 11.2.10.1
I have access to my server: Through SSH | through the webadmin | direct access via keyboard / screen | ... (all of it)
Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no

To reproduce

register
- a 3LD (e.g. name.surname.name)
- a 2LD (e.g. example.org)
add some domains to YunoHost, e.g.
- name.surname.name
- landing.example.org
- bla.example.org
- jabber.example.org
open /yunohost/admin/#/diagnosis in the browser or run yunohost diagnosis run in CLI

Expected behavior

I would expect YunoHost Diagnosis to notify me of the soon to expire (I would expect 30 days in advance) domains.

Logs

Let me know what would be useful, so I can paste the redacted logs.

zamentur commented 7 months ago

This feature to find the expiry date is not totally accurate cause it's based on the whois and some tld (eg .de) doesn't provide the expiry date at all. I don't know if it's the case with the .at.

About third level domain in .name this usecase has not been considered. We currently use the public suffix list to deduce if it's the domain registered or a subdomain of it... https://github.com/YunoHost/yunohost/blob/734e9102418faf5ddeba1338443c93a919f1ca2b/src/diagnosers/12-dnsrecords.py#L66

So i guess the solution should be to display info if yunohost can't manage the expiry date for the tld in use. So if it's a .name, or .de, or others tld doesn't providing this info in the whois...

silverhook commented 7 months ago

Better info on its limitations might be useful, yes.

YunoHost / issues