Helpers 2.1 wishlist - Githubissues

alexAubin commented 1 month ago

Drop stupid legacy v0/v1 stuff like __NAMETOREPLACE__ etc ... (some already done in bookworm maybe)
Remove the need to pass --app=$app to ynh_app_settings_set/get (or is it already optional?)
Rename ynh_app_settings_get to ynh_settings_get ?
Add a ynh_settings_set_default or something to simplify the mess during upgrade with if [[ -z "${foobar:-}" ]] ...
--full_replace=1 in ynh_setup_source should be --full_replace (cf trailing = in the args_array ...)
replace stupid 0/1 by false/true in getopts ? -Get rid of the boring "legacy args" mechanism in getopts (= positionals ? ... just enforce keyword args)
rename the logging helpers ?
homogenize options name such as --service_name vs --service, --path vs --origin_path etc
backport most of the bookworm changes etc
drop support for old .src format in ynh_setup_source ?

Salamandar commented 1 month ago

About app settings. What is the use of

    if [[ $key =~ (unprotected|protected|skipped)_ ]]; then

I can't find any settings with this name.

alexAubin commented 1 month ago

this is legacy stuff from the old permission system, it was cleaned up in bookworm

I'm working on a PR to backport most of the bookworm changes + other cleanups in a helpers 2.1 version

Salamandar commented 4 weeks ago

Fix the ynh_secure_remove clusterfuck about symlinks https://github.com/YunoHost/yunohost/pull/1716

chri2 commented 4 weeks ago

Remove the need to pass --app=$app to ynh_app_settings_set/get (or is it already optional?)

YunoHost / issues