search

YunoHost / issues

General issue tracker for the YunoHost project
72 stars 8 forks source link

Delete button not needed as the main domain can't be deleted #2480

Open ericgaspar opened 2 days ago

ericgaspar commented 2 days ago

The main domain cannot be deleted. However, we have a delete button that appears, grayed out, making us think that the main domain could be deleted (if certain conditions are met)

We should delete the delete button. (The help menu provides an explanation on why the main domain cannot be deleted)

Capture d’écran 2024-11-10 à 20 44 48

Axolotle commented 2 days ago

I think we should keep the button, as it is present on all domain info pages and the domain can actually be deleted if certain conditions are met (no longer be the main domain). Someone could search for this button and come ask if it is a bug without necessarily have read the "Main domain" info. I guess the better solution would be to implement a tooltip over disabled buttons to explain why they are disabled even if is already mentioned in the main domain info. This would improve a11y at the same time since it is the recommend way of disabling buttons (example)

ericgaspar commented 2 days ago

I can make the same remark about the DNS setting that appears in the subdomain panel with the message saying that the DNS cannot be set here but is set on the main domain panel.

Why not remove the DNS panel for sub domaines then?

It is like unused appendix in our body 😅

Axolotle commented 2 days ago

I guess I could argue in a similar way ahah, people should expects a DNS tab in a domain info page. Being able to click on the direct link to the topmost domain DNS tab is actually quite convenient so you don't have to ask yourself why there's no DNS tab, go back, click on the topmost domain, click on the DNS tab.

We also talked with Aleks about a possible improvement of domain info, we could have a view of a topmost domain with base infos card, a global DNS card, maybe a global Portal card, maybe a more general cert card, and its subdomains as a an accordion for example, clicking on a subdomain would show its specific settings, apps installed, etc. We could keep the tree like domain list as it is, clicking on a subdomain would route to the topmost domain view with this subdomain's accordion tab opened