Closed yunohost-bot closed 6 years ago
@M5oul that looks suuuuper weird, are you sure the app was installed correctly?
I do confirm the issue
ff.jb9.fr/: Funkwhale
jb9.fr/baikal: Baikal
jb9.fr/date: OpenSondage
jb9.fr/ffsync: Firefox Sync Server
jb9.fr/kanboard/: Redirect
jb9.fr/kresus: Kresus
p.jb9.fr/: PeerTube
w.jb9.fr/pixelfed: Pixelfed
jb@jb9:~$ sudo yunohost app list --installed
apps:
0:
description: Serveur CalDAV+CardDAV léger
id: baikal
installed: True
label: Baikal
license: GPL-3.0
name: Baikal
1:
description: Le serveur de synchronisation de Mozilla, pour héberger vos données Firefox
id: ffsync
installed: True
label: Firefox Sync Server
license: MPL-2.0
name: Firefox Sync Server
2:
description: A modern, convivial and free music server
id: funkwhale
installed: True
label: Funkwhale
license: BSD-3-Clause
name: Funkwhale
3:
description: Kresus est un outil personnel de gestion de finances.
id: kresus
installed: True
label: Kresus
license: AGPL-3.0-only
name: Kresus
4:
description: Mumble est un logiciel libre de voix sur IP (VoIP), son principal usage étant la communication pendant les parties de jeux en réseau.
id: mumbleserver
installed: True
label: Mumble Server
license: BSD-3-Clause
name: Mumble Server
5:
description: Mumble est un logiciel libre de voix sur IP (VoIP), son principal usage étant la communication pendant les parties de jeux en réseau.
id: mumbleserver__2
installed: True
label: Mumble Server
license: BSD-3-Clause
name: Mumble Server
6:
description: OpenSondage sert à faire des sondages sans authentification pour trouver une date de réunion qui convienne à toutes les personnes concernées.
id: opensondage
installed: True
label: OpenSondage
license: CECILL-B
name: OpenSondage
7:
description: Video streaming platform using P2P directly in the web browser, connected to a federated network
id: peertube
installed: True
label: PeerTube
license: AGPL-3.0-only
name: PeerTube
8:
description: Federated Image Sharing
id: pixelfed
installed: True
label: Pixelfed
license: MIT
name: Pixelfed
9:
description: Créer une redirection ou un proxy vers un autre emplacement
id: redirect
installed: True
label: Redirect
license: AGPL-3.0-or-later
name: Redirect
I think it's because there is no call to ynh_webpath_register
Registering URL add a domain value: https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/app.py#L1138 While listing application through map is filtering: https://github.com/YunoHost/yunohost/blob/stretch-unstable/src/yunohost/app.py#L401
It's because mumble doesn't have a domain settings entry no?
the issue was the same even before this commit: https://github.com/YunoHost-Apps/mumbleserver_ynh/commit/1e6a9211536dfe410b802ccd599fd4e8eb4b6c3f
so, if I understand the question, this means there is no connection with having a setting named domain.
An application will only appear in app_map if it has a domain (logic), if I remember correctly, before, mumble application didn't have a "domain" settings so it couldn't appear.
And if it has a domain_$something it won't appears neither.
Which is logic and the expected behavior: this app is not mapped on any domain/path.
The domain settings has been added after this ticket https://github.com/YunoHost-Apps/mumbleserver_ynh/commit/691b1abb774c7b927db4aced766d2e3099a2313a and today it's not used any more (in favor of "domain_mumble" instead) so it's expected that this app doesn't appear in "app_map" because ... it's can't be mapped.
oh, you're right, if domain
value exist in the application, it does appear:
jb@jb9:~$ sudo yunohost app setting mumbleserver domain --value="jb9.fr"
jb@jb9:~$ sudo yunohost app map
ff.jb9.fr/: Kresus
jb9.fr/: Mumble Server
jb9.fr/baikal: Baikal
jb9.fr/date: OpenSondage
jb9.fr/ffsync: Firefox Sync Server
jb9.fr/kanboard/: Redirect
jb9.fr/merde: Weblate
jb9.fr/webi: Weblate
jb9.fr/weblate: Weblate
p.jb9.fr/: PeerTube
then I assume we can close this issue as mumble's domain value was removed because of this core issue: https://github.com/YunoHost/yunohost/pull/512
or we can consider YunoHost should list apps not related to a domain. I have no opinion on this.
or we can consider YunoHost should list apps not related to a domain. I have no opinion on this.
It can't :/ This function is a "mapping" between domain/path → application, if there is not domain it's impossible to do this mapping :/
I'm closing this issue following the conclusion of this discussion, feel free to reopen.
Original Redmine Issue: 927
Author Name: moul
None