Rework and add deprecated helpers usage and deprecated practices

YunoHost / package_linter

Linter for YunoHost applications packages

https://yunohost.org/#/packaging_apps

GNU Affero General Public License v3.0

17 stars 13 forks source link

Rework and add deprecated helpers usage and deprecated practices #41

Closed alexAubin closed 5 years ago

alexAubin commented 5 years ago

This adds checks for use of deprecated helpers :

yunohost app setting
yunohost app checkurl
yunohost app checkport
yunohost app initdb
exit

As well as a check for the now deprecated use of php-fpm.ini files.

Not sure if we want this to be warnings or errors ...

alexAubin commented 5 years ago

So... working on this, I have found an important bug which causes several previous improvement to be in fact not working at all. For instance, searching for rm -rf occurrences was not working, because the way the file was read was "word by word". So the usual "rm -rf" in script syntax was not working.

This is fixed by 8060598 ...

(ping @maniackcrudelis )

maniackcrudelis commented 5 years ago

Huh why me ? What I've done !!!???

alexAubin commented 5 years ago

Just thought that you might want to read some snake :stuck_out_tongue_winking_eye:

(but also to make you aware that this is going to make a lot of new warnings appear :s )

maniackcrudelis commented 5 years ago

Well, it's not yet merged,s o it shouldn't be a problem if you fix that before. Anyway, I follow everything's happening on this repo.

And for reading cobra, I've done my part today with upgrade process...

alexAubin commented 5 years ago

Superseded by https://github.com/YunoHost/package_linter/pull/43