Report missing or bad manifest arg type, or unecessary 'choices' usage

YunoHost / package_linter

Linter for YunoHost applications packages

https://yunohost.org/#/packaging_apps

GNU Affero General Public License v3.0

17 stars 13 forks source link

Report missing or bad manifest arg type, or unecessary 'choices' usage #42

Closed alexAubin closed 5 years ago

alexAubin commented 5 years ago

The current checks for arguments type (in manifest.json) are a bit weird...

I reworked this part such that it reports :

missing argument type (as an error)
unrecognized argument type (as a warning)
use of 'choices' only to choose between 'Yes' and 'No' (or True and False). Instead, a boolean arg should be used (better for i18n ?)

This fixes https://github.com/YunoHost/package_linter/issues/2

maniackcrudelis commented 5 years ago

You can't report as an error a missing type, the type 'string' isn't in the documentation, no apps uses that type. If we want to change that and use that type, we can, but this should be raised as an warning.

alexAubin commented 5 years ago

Hmyep, didn't realize that ... (I checked yunohost's code instead of the packaging doc)

Anyway, https://github.com/YunoHost/package_linter/commit/daee832af4ec0f2d38563c955875ebe6c0473b3f should fix it : it'll report warnings instead of errors