search

YunoHost / package_linter

Linter for YunoHost applications packages
https://yunohost.org/#/packaging_apps
GNU Affero General Public License v3.0
17 stars 13 forks source link

Warnings in "[Loading App]" #65

Closed Jibec closed 4 years ago

Jibec commented 5 years ago

Hello, I have these warnings:

[Loading App]

! /home/jb//package_check/weblate_ynh_check/scripts/install : Could not parse this line (No closing quotation) : message=" ! /home/jb//package_check/weblate_ynh_check/scripts/install : Could not parse this line (No closing quotation) : " ! /home/jb//package_check/weblate_ynh_check/scripts/upgrade : Could not parse this line (No closing quotation) : mail_message=" ! /home/jb//package_check/weblate_ynh_check/scripts/upgrade : Could not parse this line (No closing quotation) : "

It comes from: https://github.com/YunoHost-Apps/weblate_ynh/blob/master/scripts/install#L314

I assume the bash script is correct, as http://shellcheck.net doesn't say anything. What do you think?

alexAubin commented 5 years ago

I assume the bash script is correct, as http://shellcheck.net doesn't say anything. What do you think?

Yes, your script is okay. It's mainly due to the way we parse the script file, which is now done line-by-line, and therefore kinda incompatible with multi-line statements ...

Still trying to think how to handle this without scaring app maintainers so much

Mickael-Martin commented 5 years ago

Same thing for me :

[Loading App]

! zabbix_ynh/scripts/install : Could not parse this line (No closing quotation) : echo "<?php ! zabbix_ynh/scripts/install : Could not parse this line (No closing quotation) : \$IMAGE_FORMAT_DEFAULT = IMAGE_FORMAT_PNG;">/usr/share/zabbix/conf/zabbix.conf.php

alexAubin commented 4 years ago

Closing because sortof fixed it a while ago: it's now not a real warning anymore + there's a message to say it's probably ok