search

YunoHost / package_linter

Linter for YunoHost applications packages
https://yunohost.org/#/packaging_apps
GNU Affero General Public License v3.0
17 stars 13 forks source link

Improve sources list detection + report messing with sources.list as an error (if not using the helpers) #70

Closed alexAubin closed 5 years ago

alexAubin commented 5 years ago

Alright folks, I really fed up about still seeing damn yunohost instance being destroyed with crazy issues related to apps who installed php 7.x via a custom repo ... Latest example being https://forum.yunohost.org/t/erreur-dinstallation-wallabag-probleme-avec-php7-0-tidy/7724

Most probably caused by Monica, but could have been any app.

So this PR improves the detection of apps messing with /etc/apt/sources.list* and reports it as an error, effectively downgrading them to level 4 (or 3 ?) though if it was me I would even just downgrade them to level 0 and tell the maintainer to just use the new helpers ...

anmol26s commented 5 years ago

We have to remove the source list from the people who have installed these app and remove any other php version then php7.0 too.

alexAubin commented 5 years ago

Flagging as ready to merge, please feel free to complain if you think this is a bad idea :stuck_out_tongue_winking_eye:

kay0u commented 5 years ago

I get the idea, and I agree that adding manually a custom repo is a bad thing. But I think this PR break something.

As far there is no helper yet to add a new repo, we have to copy paste the experimental one in _common.sh. And package_linter doesn't like it :'(

https://github.com/YunoHost-Apps/gitlab-runner_ynh/blob/master/scripts/_common.sh

last build:

https://ci-apps.yunohost.org/ci/job/3398

alexAubin commented 5 years ago

Uh yeah I don't know exactly the practices nowadays, but I see many people including the helper in a separate file, so that would not be in _common.sh ? The idea was to test also _common.sh for the presence of stuff playing with sources.list because many apps do this in there (and not in the actual script)