search

YunoHost / package_linter

Linter for YunoHost applications packages
https://yunohost.org/#/packaging_apps
GNU Affero General Public License v3.0
17 stars 13 forks source link

YEP-3.7 error #71

Closed yalh76 closed 5 years ago

yalh76 commented 5 years ago

When copying the experimental helper ynh_add_extra_apt_repos__3 into _common.sh there is a package_linter error [YEP-3.7] Manually messing with apt's sources.lists is strongly discouraged and should be avoided. Please consider alternatives like using a .deb directly or using experimental helpers (c.f. https://github.com/YunoHost-Apps/Experimental_helpers/tree/master/ynh_add_secure_repos )

because in experimental helper ynh_add_extra_apt_repos__3 there is /etc/apt/sources.list in the helper.

Does this mean that is better not to copy paste experimental helper content in _common.sh or package linter need to be corrected ?

kay0u commented 5 years ago

I think it's more a big from the linter introduced here: https://github.com/YunoHost/package_linter/pull/70

An easy way to avoid this detection is to copy paste the helper to another file (like _experimental.sh for example), and source it in the _common.sh.

But PR would be awesome too ;-)

yalh76 commented 5 years ago

_experimental.

I use to copy the experimental helper file and add source ynh_add_extra_apt_repos__3 at the beginning (best way for me to manage and update experimental helpers) but for some package that I'm not directly the maintainer, the maintainer prefer to copy paste the content of the experimental helper in _common.sh ...

I think I will do a PR on #70 saying : if there is /etc/apt/sources.list in _common.sh but not ynh_add_repo then [YEP-3.7] error (that will improve my python skills ^^ and took me hours ^^)

yalh76 commented 5 years ago

Done and tested on https://github.com/YunoHost/package_linter/pull/73

If validated and merged, several apps will increase from level 4 to level 7 ^^ and we love level 7 apps.

kay0u commented 5 years ago

[...] and we love level 7 apps.

Ho yeah!