search

YunoHost / package_linter

Linter for YunoHost applications packages
https://yunohost.org/#/packaging_apps
GNU Affero General Public License v3.0
17 stars 13 forks source link

Warning for ssowatconf #74

Closed kay0u closed 4 years ago

kay0u commented 5 years ago

https://github.com/YunoHost/package_linter/blob/bd8414ed6e8e83bc72a71191be00f57ec2029ce1/package_linter.py#L581-L582

Sometimes, we want to use yunohost app ssowatconf:

https://github.com/YunoHost/example_ynh/blob/998554426865d726f91b3be23d6f56fd52d2b0ed/scripts/install#L221

I know, it's just a warning, but I don't like the yellow on my linter :100:

(Close it if you think this issue is useless)

alexAubin commented 5 years ago

Ah yes indeed

Hmm maybe we could find some trick to check that this line is near the end of the script (usually the case for old apps)

alexAubin commented 4 years ago

Should be better with new version (only check ssowat near the end of file)