YunoHost / package_linter

Linter for YunoHost applications packages
https://yunohost.org/#/packaging_apps
GNU Affero General Public License v3.0
17 stars 13 forks source link

Error when remove old entry in conf.json.persistent #93

Closed Josue-T closed 3 years ago

Josue-T commented 3 years ago

Hello,

I'm working to remove some old entry in the file /etc/ssowat/conf.json.persistent. So I made script which remove old entry which was no more needed. But I still get this error on the liner !!!

✘ Don't do black magic with /etc/ssowat/conf.json.persistent !
alexAubin commented 3 years ago

Uh wokay but what does your script do exacly ?

Basically the linter greps line containing /etc/ssowat/conf.json.persistent ... : https://github.com/YunoHost/package_linter/blob/master/package_linter.py#L581

Josue-T commented 3 years ago

Thanks for your response:

By example: https://github.com/YunoHost-Apps/sogo_ynh/blob/permissions/scripts/remove_sso_conf_persistent.py

alexAubin commented 3 years ago

So if I understand correctly the point is to cleanup the old legacy stuff and therefore that's a legit use case ?

I guess in that case you could trick the linter by creating a var like persistent_file = '/etc/ssowat/' + 'conf.json.persistent' such that grep doesn't find it :/

Josue-T commented 3 years ago

OK, will do this, thanks

alexAubin commented 3 years ago

Closing, assuming it's fixed